Skip to content

Fix: Prevent hanging when anew is run without stdin #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noob6t5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent hanging when anew is run without stdin #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ func main() {
}
}

// ==== ADDED BLOCK: check if stdin is a terminal and bail if yes ====
fi, err := os.Stdin.Stat()
if err != nil {
fmt.Fprintf(os.Stderr, "failed to stat stdin: %v\n", err)
os.Exit(1)
}

if (fi.Mode() & os.ModeCharDevice) != 0 {
fmt.Fprintln(os.Stderr, "anew: expects input via pipe or redirection. Example:")
fmt.Fprintln(os.Stderr, " cat newthings.txt | anew things.txt")
os.Exit(1)
}
// ==== END ADDED BLOCK ====

// read the lines, append and output them if they're new
sc := bufio.NewScanner(os.Stdin)

Expand All @@ -76,3 +90,4 @@ func main() {
}
}
}