Skip to content

Fix directory traversal vulnerability #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
young-versacall wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix directory traversal vulnerability #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e5f12
Fix directory traversal vulnerability
young-versacall Feb 13, 2019
804159f
original project.lock.json
young-versacall Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/WebServer/File/StaticFileRouteHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ public async Task<HttpServerResponse> HandleRequest(IHttpServerRequest request)
var localFilePath = GetFilePath(request.Uri);
var absoluteFilePath = GetAbsoluteFilePath(localFilePath);

// Check to make sure the requested path isn't outside the base path.
if (!absoluteFilePath.ToLower().StartsWith(_basePath.ToLower()))
{
return GetBadRequestResponse("Navigation outside of allowed path.");
}


// todo: add validation for invalid path characters / invalid filename characters
IFile item;
try
Expand All @@ -65,6 +72,16 @@ private static HttpServerResponse GetFileNotFoundResponse(string localPath)
return notFoundResponse;
}

private static HttpServerResponse GetBadRequestResponse(string message)
{
var response = HttpServerResponse.Create(new Version(1, 1), HttpResponseStatus.BadRequest);
response.Content = Encoding.UTF8.GetBytes(message);
response.ContentType = "text/plain";
response.ContentCharset = "utf-8";

return response;
}

private static HttpServerResponse GetMethodNotAllowedResponse(HttpMethod? method)
{
// https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
Expand Down Expand Up @@ -110,7 +127,7 @@ private string GetAbsoluteFilePath(string localFilePath)
{
var absoluteFilePath = Path.Combine(_basePath, localFilePath);

return absoluteFilePath;
return Path.GetFullPath(absoluteFilePath);
}

private static string GetLocalPath(string uriString)
Expand Down