Repository navigation
Add Filmic, ACES and AgX tone mapping - #548
Merged
Merged
Conversation
Select the operator with a ToneMapper enum passed to SceneTarget::resolve(). Reinhard stays the default. A Tone Map tab in the debug UI picks it, and the choice is saved as video.toneMapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three tone mapping operators next to Reinhard (card 92).
tonemap.slang:toneMapperuniform selects Reinhard, Filmic (Uncharted 2), ACES (Narkowicz fit) or AgX (minimal polynomial). Each returns linear display light, so the single gamma encode and dither are unchanged.SceneTarget::resolve()takes aToneMapperenum. It travels through the frame snapshot andMazeLayerundersettingsMutex.video.toneMapper; invalid values fall back to Reinhard, which stays the default.Not done: the options screen has no selector, and bloom threshold and intensity are still tuned for Reinhard.
Verified: debug build, 30-frame
--capture-framesrun with no GL errors (Reinhard only),pre-commit run --all-files.