Sylius 20 adaptation - #1
Conversation
| "require": { | ||
| "php": "^8.0", | ||
| "sylius/sylius": ">=1.11 <1.14" | ||
| "sylius/sylius": "^2.0.0-alpha.2" |
There was a problem hiding this comment.
This should be enough and cover you until the stable release is done. As Sylius v2.0.0-ALPHA-3 was just released and it is planned to go up to ALPHA-5 before the BETA releases start. You will not need to to upgrade all these packages with every alpha there is.
| "sylius/sylius": "^2.0.0-alpha.2" | |
| "sylius/sylius": "^2.0.0@alpha" |
| $currentLocale = $fallbackLocale; | ||
| } | ||
|
|
||
| $queryBuilder = $this->entityManager->getConnection()->createQueryBuilder(); |
There was a problem hiding this comment.
Shouldn't this be moved to a MenuItemRepository?
| $menu = $event->getMenu(); | ||
| if (null !== $content = $menu->getChild('configuration')) { | ||
| $content->addChild('app-menu', ['route' => 'monsieurbiz_menu_admin_menu_index']) | ||
| $content->addChild('menu_type', ['route' => 'monsieurbiz_menu_admin_menu_index']) |
There was a problem hiding this comment.
Why do we need to update the name here? Something changed in Sylius 2.0 regarding the admin menu builder?
| protected string $code = self::PROVIDER_CODE; | ||
|
|
||
| protected string $icon = 'folder'; | ||
| protected string $icon = 'world'; |
There was a problem hiding this comment.
Is the folder icon missing in new admin css? It would be best to keep the icon which was initially chosen by the plugin creators.
| use Doctrine\Common\Persistence\ManagerRegistry; | ||
| use Doctrine\ORM\Query\Expr; | ||
| use MonsieurBiz\SyliusMenuPlugin\Entity\MenuInterface; | ||
| use MonsieurBiz\SyliusMenuPlugin\Entity\MenuItem; |
There was a problem hiding this comment.
These uses seem to be a leftover and are not used anywhere
|
|
||
| use Doctrine\Common\Persistence\ManagerRegistry; | ||
| use MonsieurBiz\SyliusMenuPlugin\Entity\MenuInterface; | ||
| use MonsieurBiz\SyliusMenuPlugin\Entity\Menu; |
…rm-display feat(form): update menu item to put technical option at the end
…ale-condition Fix: avoid server error with a product without slug for wanted locale
5f714ca to
53ec104
Compare
78e8c74 to
ece8901
Compare
use directly live component without custom stimulus controller
2 participants
No description provided.