Course Schedule Ii#146
Open
tom4649 wants to merge 2 commits into
Open
Conversation
nodchip
reviewed
Jul 12, 2026
| # 0: 未訪問, 1: 訪問中, 2: 訪問ずみ | ||
| status = [0] * numCourses | ||
|
|
||
| def dfs(i): |
There was a problem hiding this comment.
関数名は通常英単語の原形または命令形、もしくは助動詞などで始まることが多いと思います。また、関数名にはその関数が何をするのか、何が返ってくるのかを表す英単語・英語句を付けることをお勧めいたします。 dfs は実装の詳細に深入りしすぎているように感じます。 visit_course や can_finish_from などはいかがでしょうか？
| adjacent_list[first].append(second) | ||
|
|
||
| order = [] | ||
| # 0: 未訪問, 1: 訪問中, 2: 訪問ずみ |
There was a problem hiding this comment.
マジックナンバーとなっているのが気になりました。 enum の仕様をお勧めいたします。
https://docs.python.org/ja/3/library/enum.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/course-schedule-ii/description/