Repository navigation
Conversation
Fixes the 7 pre-existing type errors that make the TSLint CI job permanently red regardless of what a PR changes: - mod_interface.js: afterPrams/extendsPrams used tuple types with a non-trailing or duplicate rest element, which needs TS >=4.0 while this repo is pinned to typescript@3.9.3. Simplified to (...args: any[]). - game_analytics.js: window.setAbt was assigned without being declared on the Window interface augmentation in globals.d.ts. - main_menu.js / preload.js: querySelector results typed as Element were accessed via .innerText/.style, which only exist on HTMLElement. - preload.js: setStatus(text, progress) was called with only one argument; progress is now marked optional in its JSDoc.
Contributor
Author
|
Hi @tobspr |
Collaborator
|
This repo is no longer maintained, see the README. Also none of us trust that you understand the PR you manifested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1646.
Fixes the 7 pre-existing type errors that make the
TSLintCI job permanently red regardless of what a PR changes:mod_interface.js:afterPrams/extendsPramsused tuple types with a non-trailing or duplicate rest element, which needs TS >=4.0 while this repo is pinned totypescript@3.9.3. Simplified to(...args: any[]).game_analytics.js:window.setAbtwas assigned without being declared on theWindowinterface augmentation inglobals.d.ts.main_menu.js/preload.js:querySelectorresults typed asElementwere accessed via.innerText/.style, which only exist onHTMLElement.preload.js:setStatus(text, progress)was called with only one argument;progressis now marked optional in its JSDoc.Verified locally by reproducing the CI steps (
gulp translations.fullBuild,gulp localConfig.findOrCreate, thenyarn lintandyarn tslint) — both now pass with no errors.