Skip to content

620 product catalog jonathan - #35

Open
hrodrigues-hestia wants to merge 11 commits into
candidatesfrom
620-Product-Catalog-Jonathan
Open

620 product catalog jonathan#35
hrodrigues-hestia wants to merge 11 commits into
candidatesfrom
620-Product-Catalog-Jonathan

Conversation

@hrodrigues-hestia

Copy link
Copy Markdown
Collaborator

changes regarding:

https://github.com/tmforum-rand/TMF620_Product_Catalog

No tests done.

@hrodrigues-hestia hrodrigues-hestia added the enhancement New feature or request label Apr 1, 2019
@hrodrigues-hestia hrodrigues-hestia self-assigned this Apr 1, 2019
@knutaa

knutaa commented Apr 1, 2019

Copy link
Copy Markdown
Contributor
  1. Suggest to not add trailing space after each property, e.g.
    "type": "string", (with trailing space)
    should just be
    "type": "string", (without the trailing space) - many similar examples

  2. Suggest to use local references, e.g. keep

"$ref": "CategoryRef.schema.json#CategoryRef" 

and not introduce the navigation up and back again, not like

"$ref": "../product/CategoryRef.schema.json#CategoryRef"
  1. Suggest to avoid unnecessary abbreviations, e.g. use long form and not abbreviations like PLA (Pricing Logic Algorithm)

  2. Comment A JSON-Schema template for TM Forum entities #1 above is relevant also for the new schemas, not only for the modified schemas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants