Skip to content

Exclude macrocycle rings for rest region expansion by default#132

Merged
badisa merged 4 commits into
masterfrom
task/exclude-macrocycle-rings-from-rest-region
Jun 8, 2026
Merged

Exclude macrocycle rings for rest region expansion by default#132
badisa merged 4 commits into
masterfrom
task/exclude-macrocycle-rings-from-rest-region

Conversation

@badisa

@badisa badisa commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator
  • The 3RKZ set of macrocycles perform worse with REST partially due to the REST region expanding to the entire macrocycle ring. This change limits the ring expansion logic to up to 7 atom rings.

All of the macrocycle sets were run in tmd-industries/rbfe-datasets#20 Ftase got worse, but everything else seems like a wash. Since not including the entire macrocyclic ring is less surprising, it seems like a more desirable result even if it may help in some cases.

3RKZ Before

image

3RKZ After

image

badisa added 4 commits June 4, 2026 17:58
default

* Including a Macrocycle's entire ring in the REST region tends to over
  sample in the complex leg.
@badisa badisa merged commit e393f94 into master Jun 8, 2026
8 checks passed
@badisa badisa deleted the task/exclude-macrocycle-rings-from-rest-region branch June 8, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant