Switch to Using Heavy Matches Heavy Atom mappings#10
Merged
Conversation
* Things are faster, but needs a bit more analysis to be sure that this is a net improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Note that in #9 there was an issue with the OpenFE preparation, so it is different in notable ways to the previous sets.
Summary
Overall the total nanoseconds simulated changed from +2% nanoseconds to -30% nanoseconds simulated. The average reduction in nanoseconds appears to be about 10%.

The overall rank correlation held out for larger datasets, but suffered for the smaller sets which are more sensitive to run to run variability

One such example is Factor Xa, where a minor change in the prediction swaps the ranking of two compounds and produces a -1 correlation

The one set that stood out from this was BACE, which is covered in more detail below.
BACE
Looking through the results the BACE dataset stood out as a set that got worse. To investigate, multiple replicates were run with and without the new maps to see how the performance changes. Despite a significant change to the previous BACE results, the replicates with the old and new maps produced similar results.
Looking closer it became apparent that the preparation of the datasets from OpenFE was wrong and tearing out more than intended. In the case of BACE there are crystal waters that were removed. Re-running the performance looks more in line with previous references
The performance of the heavy matches heavy is still slightly worse than the previous atom mapping, but for consistency will stay with the new map. The atom mapping protocol may be useful to tweak for different systems, which is already an expectation.
Next Steps