fix(test): isolate HF hub cache in test_registry_discover (#101)#102
Merged
lgsunnyvale merged 1 commit intoJul 20, 2026
Merged
Conversation
unsetenv(MLXD_HF_HUB_DIR) let reg_hf_hub_dir() fall through to the real $HOME/.cache/huggingface/hub, inflating discovery counts. Point the four fixture-only tests at /nonexistent instead.
lgsunnyvale
approved these changes
Jul 20, 2026
lgsunnyvale
deleted the
test_registry_discover-fails-due-to-leaking-real-hf-hub-cache
branch
July 20, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_registry_discoverno longer leaks the real HF hub cache.MLXD_HF_HUB_DIR=/nonexistentinstead of unsetting it, soreg_hf_hub_dir()cannot fall through to$HOME/.cache/huggingface/hub.Test plan
./tests/test_registry_discoverfails withassert(count == 2)when real HF models are present./tests/test_registry_discoverpassestest_registry_discovercleanmake test- 43 passed, 0 failed