This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add the user-agent and the remote address ip#546
Open
huguesjoyal wants to merge 2 commits into
Open
Conversation
|
@tlaverdure could be merged? |
PaolaRuby
added a commit
to PaolaRuby/framework
that referenced
this pull request
Nov 23, 2021
tlaverdure/laravel-echo-server#546 When request doesn't has `ipAddress` or 'User-Agent' don't overwrite the last one
PaolaRuby
added a commit
to PaolaRuby/framework
that referenced
this pull request
Nov 23, 2021
tlaverdure/laravel-echo-server#546 In some cases request doesn'nt has `ipAddress` or `userAgent`, with this change it avoid overwrite the last reported data
PaolaRuby
added a commit
to PaolaRuby/framework
that referenced
this pull request
Nov 24, 2021
tlaverdure/laravel-echo-server#546 In some cases request doesn'nt has `ipAddress` or `userAgent`, with this change it avoid overwrite the last reported data
PaolaRuby
added a commit
to PaolaRuby/framework
that referenced
this pull request
Nov 24, 2021
tlaverdure/laravel-echo-server#546 In some cases request doesn'nt has `ipAddress` or `userAgent`, with this change it avoid overwrite the last reported data
|
@tlaverdure ping , hi?? |
msonowal
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Private channel, laravel-echo-server is sending a request to the apps (/broadcasting/auth). The user agent being empty and the remote address being the laravel-echo-server, the session is updated with the new info, which can cause a problem when using database sessions.
Here is an example problem :
https://laracasts.com/discuss/channels/laravel/user-session-user-agent-and-ip-address-fields-are-corrupt-when-using-laravel-echo-server
My suggestion is to add an X-Forwarded-For with the remote client IP and add the User-Agent.
To get the correct client IP address on the laravel side, we need to set up the laravel-echo-server IP address as a trusted proxy.
https://laravel.com/docs/master/requests#configuring-trusted-proxies