flexible source dir - #72
Open
rukyr97 wants to merge 5 commits into
Open
Conversation
pgawlowicz
force-pushed
the
app-ns-3.36+
branch
2 times, most recently
from
May 9, 2023 18:50
72996bb to
6007f4b
Compare
Contributor
|
Thank you for explanation. Indeed, might be a nice feature for some users. Could you clean the commit history and provide only 1 commit with the feature? The two first commits are already in main repo, so just the code allowing to set the src dir. |
rukyr97
force-pushed
the
app-ns-3.36+
branch
2 times, most recently
from
May 10, 2023 09:33
e67cfa3 to
bc10b33
Compare
Contributor
Author
|
It is done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, users no longer need to move the full ns3-gym repo into the contrib folder of ns-3. Instead, they can use symbolic links.
This wasn't possible without this patch because the code was dependent of the output of
os.getcwd(). Herein, the default behavior remains the same. However, we can specify with the optionalsource_dirparameter, what is the working directory that we want to define as the source directory.