Skip to content

fixed error in get_thunderstorms: gemeinde -> gemeindenr - #2

Merged
tklecka merged 3 commits into
tklecka:mainfrom
a7rk:main
Aug 6, 2026
Merged

fixed error in get_thunderstorms: gemeinde -> gemeindenr#2
tklecka merged 3 commits into
tklecka:mainfrom
a7rk:main

Conversation

@a7rk

@a7rk a7rk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

API returns gemeindenr not gemeinde

@tklecka tklecka left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is right — the live endpoint returns gemeindenr, so get_thunderstorms() was failing on every call.

Two things before merge:

  1. tests/test_client.py still uses "gemeinde" in its fixtures, so test_get_thunderstorms fails with this patch (Could not parse thunderstorm response: 'gemeindenr'). CI hasn't reported on this PR, so it went unnoticed.

  2. test_get_thunderstorms_malformed is meant to cover a missing intensitaet, but now raises on the missing gemeindenr instead. Needs {"gemeindenr": 1} to keep testing what it intends.

Minor: .gitignore lost its trailing newline.

fixed `gemeindenr` in `get_thunderstorms` methods

@tklecka tklecka left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests updated, suite is green (20 passed), ruff and mypy clean. Thanks!

Only leftover is the missing trailing newline in .gitignore — not worth another round-trip, I'll fix it after merge.

@tklecka
tklecka merged commit 0e85cf8 into tklecka:main Aug 6, 2026
3 of 4 checks passed
tklecka added a commit that referenced this pull request Aug 6, 2026
Both were failing `ruff format --check` in CI; the README code block
predates #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants