fixed error in get_thunderstorms: gemeinde -> gemeindenr - #2
Conversation
tklecka
left a comment
There was a problem hiding this comment.
Fix is right — the live endpoint returns gemeindenr, so get_thunderstorms() was failing on every call.
Two things before merge:
-
tests/test_client.pystill uses"gemeinde"in its fixtures, sotest_get_thunderstormsfails with this patch (Could not parse thunderstorm response: 'gemeindenr'). CI hasn't reported on this PR, so it went unnoticed. -
test_get_thunderstorms_malformedis meant to cover a missingintensitaet, but now raises on the missinggemeindenrinstead. Needs{"gemeindenr": 1}to keep testing what it intends.
Minor: .gitignore lost its trailing newline.
fixed `gemeindenr` in `get_thunderstorms` methods
tklecka
left a comment
There was a problem hiding this comment.
Tests updated, suite is green (20 passed), ruff and mypy clean. Thanks!
Only leftover is the missing trailing newline in .gitignore — not worth another round-trip, I'll fix it after merge.
Both were failing `ruff format --check` in CI; the README code block predates #2.
API returns
gemeindenrnotgemeinde