fix: restrict decrypt output file permissions to 0600#108
Draft
valet-valet-turnkey-dev[bot] wants to merge 1 commit into
Draft
fix: restrict decrypt output file permissions to 0600#108valet-valet-turnkey-dev[bot] wants to merge 1 commit into
valet-valet-turnkey-dev[bot] wants to merge 1 commit into
Conversation
Cure53 audit finding TUR-02-002: the writeFile() helper used by the decrypt command created output files with 0644 permissions, making decrypted plaintext (private keys, mnemonics) readable by other users on the system. Change the permission mode from 0644 to 0600 (owner read/write only) so that sensitive output files are not world- or group-readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Cure53 audit finding TUR-02-002 (ENG-2291).
Problem
The
writeFile()helper insrc/cmd/turnkey/pkg/root.gowrote output files with0644permissions. This means any user on the system can read files written by thedecryptcommand, including decrypted private keys and mnemonics.Fix
Change the permission mode from
0644to0600(owner read/write only). This is the only file-write call site in the CLI; no other permissive modes were found.References