Skip to content

style: fix pre-existing cargo fmt violations#167

Closed
daniilrrr wants to merge 1 commit into
mainfrom
daniil/fix-cargo-fmt
Closed

style: fix pre-existing cargo fmt violations#167
daniilrrr wants to merge 1 commit into
mainfrom
daniil/fix-cargo-fmt

Conversation

@daniilrrr

@daniilrrr daniilrrr commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The checked-in code on main does not satisfy cargo fmt -- --check when run under the repo's pinned toolchain (1.88, per rust-toolchain.toml) — i.e. what make lint uses locally. This PR applies the formatting that pinned-1.88 rustfmt wants.

Why does main's CI show green, then? Because CI does not currently use the pinned toolchain — it lints under stable. See #168 for the toolchain-mismatch fix and the full root-cause writeup. This PR fixes the formatting itself so it's clean under both toolchains.

Formatting changes ONLY — no logic changes.

Files reformatted

  • tvc/src/client.rs — import ordering: use turnkey_client::generated::GetTvcAppRequest; now sorts before use turnkey_client::generated::external::data::v1::TvcApp;
  • tvc/src/commands/display.rsyes_no collapsed to the edition-2024 short-if style: if value { "yes" } else { "no" }

Verification

  • Reproduced on main (5b6c776): cargo fmt -- --check exits 1 under pinned 1.88 (rustfmt 1.8.0-stable, cargo 1.88.0), flagging the two files above.
  • After this PR's changes, cargo fmt -- --check exits 0 under pinned 1.88.
  • git diff main --stat shows only these two files (3 insertions, 7 deletions) — pure whitespace/import-ordering/short-if churn.
  • No generated files under client/src/generated/ were touched.

This is fmt-only and intentionally does not touch the clippy lint / AGENTS.md work from PR #166 or the CI-pin in #168. See #168 for which commit introduced the drift and the toolchain root cause.

@daniilrrr

Copy link
Copy Markdown
Contributor Author

folding this into #168

@daniilrrr daniilrrr closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants