qos_core: unify ports into system range#738
Draft
Turnalek wants to merge 1 commit into
Draft
Conversation
- port 2000 for control both qos_host http and vsock internal - port 2001 for egress bridge - port 3000+ for app/user use
1091634 to
f0e9d93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
Unifies our internal and external port structure with the following basic rule:
< 3000are reserved "system" ports and are not to be used by pivot apps/users>= 3000are app ports to be used as users needCurrently we are operating these ports:
vsockport3used by the enclaveinit/reaperandqos_hostfor boot instruction messagingvsockandtcpport3000used bypivot/appandqos_bridgeas ingress default app port for app hosting functionalityvsockandip (both tcp and udp)port1000used byqos_bridgeenclave-side and host-side for egress bridgingSince ports
<= 1024are only usable byroot, and to unify our port structure better this PR changes:vsockport3is now2000- this enabled root-less local hosting forqemurunsvsockandipport1000is now2001- this removes theqemucompile time feature switch and unifies thingshttpport3001used byqos_hostis now2000to match the controlvsockport it forwards to and to free ports>= 3000for app useNOTE: this PR needs #737 merged and mono and tvc follow ups (TODO)
How I Tested These Changes
Locally so far
Pre merge check list