Skip to content

Update hickory-resolver#691

Open
cr-tk wants to merge 4 commits into
mainfrom
christian/hickory_patch2
Open

Update hickory-resolver#691
cr-tk wants to merge 4 commits into
mainfrom
christian/hickory_patch2

Conversation

@cr-tk

@cr-tk cr-tk commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Summary & Motivation (Problem vs. Solution)

Switch to a new minor version of hickory-resolver, primarily motivated by known issues in 0.25.2.

How I Tested These Changes

CI only

Pre merge check list

TBD.

  • Call out updates and breaking changes via conventional commits
  • Communicate verification flow breaking changes especially thoroughly. If any of the following answers are no, then this is a verification flow breaking change:
    • Can enclaves in a previous QOS version still key forward to this new version?
    • Can previous versions of QOS verify attestations from this new version?
    • Can manifests generated by a previous version still be parsed by this one?
    • Can previous approvals still be verified against a manifest (i.e. is this a non-breaking change to the manifest signing payload)?
    • Can a previous version of QOS still perform a boot standard on an enclave of this version?

@cr-tk cr-tk added the bug Something isn't working label May 8, 2026
@socket-security

socket-security Bot commented May 8, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedrand@​0.10.110010093100100
Addedrand_core@​0.10.010010093100100
Updatedhickory-resolver@​0.25.2 ⏵ 0.26.19510093100100

View full report

@cr-tk

cr-tk commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

@emostov is this ready to go out of draft mode?

@emostov emostov marked this pull request as ready for review May 21, 2026 18:23
@emostov emostov requested review from a team as code owners May 21, 2026 18:23
@emostov

emostov commented May 21, 2026

Copy link
Copy Markdown
Contributor

@emostov is this ready to go out of draft mode?

Yes just needs dep review

@cr-tk cr-tk force-pushed the christian/hickory_patch2 branch from 8646fc2 to 2be10e8 Compare June 19, 2026 20:08
@cr-tk

cr-tk commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased the branch against main to account for some minor Cargo.lock changes there, which led to a merge conflict.

@cr-tk cr-tk force-pushed the christian/hickory_patch2 branch from 2be10e8 to c148c43 Compare June 19, 2026 21:12
@cr-tk

cr-tk commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Drop a commit that removed dnssec-ring, which we want to keep for DNSSEC support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants