Skip to content

Enable namedGroups in regjsparser - #751

Open
kapouer wants to merge 1 commit into
tjenkinson:mainfrom
kapouer:main
Open

Enable namedGroups in regjsparser#751
kapouer wants to merge 1 commit into
tjenkinson:mainfrom
kapouer:main

Conversation

@kapouer

@kapouer kapouer commented Jul 24, 2025

Copy link
Copy Markdown

Address #249.
Maybe more work is needed ? It's a necessary first step anyway.

@kapouer
kapouer requested a review from tjenkinson as a code owner July 24, 2025 13:28
@tjenkinson

Copy link
Copy Markdown
Owner

Thanks but more work is needed to actually handle the named groups

@kapouer

kapouer commented Jul 24, 2025

Copy link
Copy Markdown
Author

Maybe not all work, but at least I could get some feedback about

/^(?:(?<tenant>[a-z0-9]+)-)?(?<id>[a-z0-9]+)(?<domain>\.[a-z0-9]+\.[a-z]+)$/

which is fixed by

/^(?:(?<tenant>[a-z0-9]{1,16})-)?(?<id>[a-z0-9]{1,32})(?<domain>\.[a-z0-9]+\.[a-z]+)$/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants