This repository was archived by the owner on Jul 13, 2026. It is now read-only.
fix: use apiPublicGet for /v1/spot/status endpoint#333
Merged
Conversation
/v1/spot/status は api.bitbank.cc 配下のエンドポイントだが、 public.bitbank.cc に prefix する publicGet を使っていたため bitbank status が常に HTTP 404 になっていた。 pairs.ts と同様に apiPublicGet を使うよう修正。 再発防止: - status.test.ts にリクエスト URL の検証を追加（pairs.test.ts と同型） - chaos x19 を新設: publicGet に /v1/ path を渡していないか、 apiPublicGet が /v1/ path のみかを呼び出し側リテラルで静的検査 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QHckt8uYZCWmW7pX1gcpv
📝 WalkthroughSummary
Category
Risk Level
Impact
Walkthroughstatus コマンドの呼び出し先が Changesstatus のホスト切り替え
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/__tests__/chaos/conventions/x19-host-path-mapping.test.ts`:
- Line 12: CALL_RE currently only captures literal path text, so it misses calls
where apiPublicGet/publicGet uses a template literal with a dynamic prefix.
Update the extraction logic in x19-host-path-mapping.test to recognize template
literals whose leading segment is a variable interpolation, and flag those cases
separately instead of treating them as a normal static path. Keep the existing
static-string handling for current files like pairs.ts and status.ts, but ensure
the test still detects host/path mix-ups even when the path starts with an
expression.
- Around line 46-52: The self-check in x19-host-path-mapping.test.ts is too
coarse because it only asserts a combined count for publicGet and apiPublicGet,
so one function can disappear without failing the test. Update the test around
the CALL_RE scan in the x19-host-path-mapping suite to count each call
separately and assert both publicGet and apiPublicGet are present independently.
Use the existing identifiers publicGet, apiPublicGet, CALL_RE, and tsFilesUnder
so the guard still detects when either branch of the host-path mapping logic is
removed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 40251adb-677d-46a6-812b-eb155764a9e8
📒 Files selected for processing (3)
cli/__tests__/chaos/conventions/x19-host-path-mapping.test.tscli/__tests__/public/status.test.tscli/commands/public/status.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
bitbankinc/bitbank-api-docs(manual)
CodeRabbit レビュー (#333) の 2 指摘に対応: - 自壊検知を publicGet / apiPublicGet の個別カウントに変更。 片方の呼び出しが全滅しても検知できるようにする - path 先頭が変数展開のテンプレートリテラルは host 選択を 静的検査できないため violation としてフラグする Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QHckt8uYZCWmW7pX1gcpv
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cli/__tests__/chaos/conventions/x19-host-path-mapping.test.ts (1)
27-39: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win動的テンプレートリテラルの
apiPublicGet呼び出しで偽陽性の違反が重複発生します。
pathが"${"から始まる場合（Line 35-39 の新チェック対象）、Line 30 の!path.startsWith("/v1/")も真になってしまうため、apiPublicGet呼び出しに対して「market data 系は publicGet を使う」という誤った違反（実際は静的に判定不能なだけ）が Line 35-39 の「静的検査不能」違反と同時に重複して出力されます。動的パスを持つapiPublicGet呼び出しが将来追加されると、このテストは常に失敗し続け、原因追跡が混乱します。
path.startsWith("${")のケースは、既存の /v1/ 判定より先に判定して以降の判定をスキップするべきです。💡 対応例
for (const m of src.matchAll(CALL_RE)) { const [, fn, path] = m; const line = src.slice(0, m.index).split("\n").length; + if (path.startsWith("${")) { + violations.push( + `${file}:${line}: ${fn}(\`${path}...\`) — path 先頭が変数展開だと host 選択を静的検査できない。先頭は文字列リテラルにする`, + ); + continue; + } if (fn === "publicGet" && path.startsWith("/v1/")) { violations.push(`${file}:${line}: publicGet("${path}...") — /v1/ 系は apiPublicGet を使う`); } if (fn === "apiPublicGet" && !path.startsWith("/v1/")) { violations.push( `${file}:${line}: apiPublicGet("${path}...") — market data 系は publicGet を使う`, ); } - if (path.startsWith("${")) { - violations.push( - `${file}:${line}: ${fn}(\`${path}...\`) — path 先頭が変数展開だと host 選択を静的検査できない。先頭は文字列リテラルにする`, - ); - } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cli/__tests__/chaos/conventions/x19-host-path-mapping.test.ts` around lines 27 - 39, The host-path mapping checks are producing duplicate violations for dynamic template-literal paths in apiPublicGet. Update the convention logic in x19-host-path-mapping.test.ts so the path.startsWith("${") case is handled first and short-circuits further checks, preventing the later !path.startsWith("/v1/") branch from also reporting a false “use publicGet” violation for the same call.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@cli/__tests__/chaos/conventions/x19-host-path-mapping.test.ts`:
- Around line 27-39: The host-path mapping checks are producing duplicate
violations for dynamic template-literal paths in apiPublicGet. Update the
convention logic in x19-host-path-mapping.test.ts so the path.startsWith("${")
case is handled first and short-circuits further checks, preventing the later
!path.startsWith("/v1/") branch from also reporting a false “use publicGet”
violation for the same call.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c6ee5fe8-3e07-4f8f-8524-00810d412134
📒 Files selected for processing (1)
cli/__tests__/chaos/conventions/x19-host-path-mapping.test.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
bitbankinc/bitbank-api-docs(manual)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
status.tsが誤ってpublicGetで/v1/spot/statusを呼び出していた問題を修正しました。/v1/系エンドポイントはapi.bitbank.ccのapiPublicGetを使う必要があります。変更内容
publicGet→apiPublicGetに修正api.bitbank.cc）を呼び出していることを検証するテストを追加publicGet/apiPublicGetの呼び出しと path の対応を静的に検査する chaos テスト背景
publicGet→public.bitbank.cc（market data 系:/ticker,/tickers等）apiPublicGet→api.bitbank.cc（/v1/spot/*系）呼び出し側の path 先頭リテラルで host 選択を静的に検査することで、コンパイルは通るが実行時に HTTP 404 になる問題を防ぎます。
チェックリスト
npx vitest runが greennpx tsc --noEmitが greennpx biome check cli/が greencli/__tests__/chaos/conventions/）を満たすhttps://claude.ai/code/session_017QHckt8uYZCWmW7pX1gcpv