Handle cells containing OSC 8 hyperlinks#145
Open
hlascelles wants to merge 1 commit into
Open
Conversation
`Terminal::Table::Util.ansi_escape` strips ANSI CSI escape sequences (e.g. SGR color codes) when computing a cell's visible width, but it does not recognize OSC 8 hyperlink escape sequences (`\e]8;;URL\e\\text\e]8;;\e\\` or the BEL-terminated variant ``\e]8;;URL\atext\e]8;;\a`). As a result, any cell whose value includes a terminal hyperlink is measured as if the escape sequence bytes were visible characters, inflating the calculated column width and breaking table alignment/borders. This PR caters for those hyperlink sequences.
hlascelles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal::Table::Util.ansi_escapestrips ANSI CSI escape sequences (e.g. SGR color codes) when computing a cell's visible width, but it does not recognize OSC 8 hyperlink escape sequences (\e]8;;URL\e\\text\e]8;;\e\\or the BEL-terminated variant\e]8;;URL\atext\e]8;;\a).As a result, any cell whose value includes a terminal hyperlink is measured as if the escape sequence bytes were visible characters, inflating the calculated column width and breaking table alignment/borders.
This PR caters for those hyperlink sequences.