Skip to content

fix: vite@8 build compatibility #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tivac merged 3 commits into from
Sep 1, 2026
Merged

fix: vite@8 build compatibility #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e1c451
fix: vite@8 build compatibility
tivac Sep 1, 2026
d625d1b
chore: fix lint issue
tivac Sep 1, 2026
8d9a761
docs: add changeset
tivac Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/funny-banks-bet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@modular-css/vite": patch
---

fix: vite@8 build compatibility

Vite plugins can return `moduleSideEffects` from their `transform` hook, but with the switch to Rolldown for built output the valid arguments changed.
7 changes: 3 additions & 4 deletions packages/vite/vite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ module.exports = (
return this.error(e);
}

const { code : css, namedExports, warnings } = transform(file, processor, pluginOptions);
const { code : css, warnings } = transform(file, processor, pluginOptions);

warnings.forEach((warning) => {
this.warn(warning);
Expand Down Expand Up @@ -253,9 +253,8 @@ module.exports = (
code : result,
map : emptyMappings,

// Disable tree-shaking for CSS modules w/o any classes/values to export
// to make sure they're included in the bundle
moduleSideEffects : Boolean(namedExports.length) || "no-treeshake",
// Disable tree-shaking for CSS modules to make sure they're included in the bundle
moduleSideEffects : true,
};
},
};
Expand Down