sx127x: add functions used for FSK radio communication - #823
Conversation
|
Review requested please! 😸 |
HattoriHanzo031
left a comment
HattoriHanzo031
left a comment
There was a problem hiding this comment.
Just some small, non-functional adjustments for clarity/consistency.
| d.spiRxBuf = append(d.spiRxBuf, 0) | ||
| d.spi.Tx(nil, d.spiRxBuf) | ||
| d.controller.SetNss(true) | ||
| if d.controller != nil { |
There was a problem hiding this comment.
Is there a use-case of using the driver without the controller? If yes, maybe we could in New set the default nopControler that does nothing to avoid this checks.
There was a problem hiding this comment.
I would like to leave that question for a future PR.
| controller RadioController // to manage interrupts with the radio | ||
| deepSleep bool // Internal Sleep state | ||
| deviceType int // sx1261,sx1262,sx1268 (defaults sx1261) | ||
| deviceType int // sx1272, sx1273, sx1276, sx1279 (defaults sx1276) |
There was a problem hiding this comment.
deviceType is actually not used anywhere
There was a problem hiding this comment.
That was an oversight on my part, I think. I have added SetDeviceType() to make consistent with sx126x.
f68682a to
5ffd6fa
Compare
|
Thanks for the feedback @HattoriHanzo031 I have made a few updates. I also added a smoketest for the |
HattoriHanzo031
left a comment
HattoriHanzo031
left a comment
There was a problem hiding this comment.
Looks good to me (after unused constants are removed)
Signed-off-by: deadprogram <ron@hybridgroup.com>
5ffd6fa to
37ca66b
Compare
2 participants
This PR adds a few missing functions to the
sx127xthat are used for FSK radio communication. It also cleans up a few existing functions to clarify the implementation. Also tested that Lora still works!