Skip to content

fix(ui): safely render conversation display text#154

Open
xz-dev wants to merge 1 commit into
tintinweb:masterfrom
xz-dev:fix/conversation-viewer-safe-display
Open

fix(ui): safely render conversation display text#154
xz-dev wants to merge 1 commit into
tintinweb:masterfrom
xz-dev:fix/conversation-viewer-safe-display

Conversation

@xz-dev

@xz-dev xz-dev commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a late, display-only safety gate for externally derived ConversationViewer text
  • replace binary-like display bodies with [binary content] and visibly escape terminal-unsafe code points without mutating session messages
  • route message bodies, tool data, streaming activity, header metadata, model names, and invocation tags through the same gate
  • preserve exact-width rows while bounding multiline header/composer rendering to the overlay height
  • apply display limits by Unicode code point before classification and escaping

Scope

This is intentionally a separate follow-up to #153 rather than an amendment to that PR. It builds on the exact-width rendering fix already merged there, but the display-safety changes span the viewer, activity and invocation-tag rendering, dependency metadata, and regression coverage.

No agent behavior, AgentSession.messages, model context, persistence, resume/fork behavior, or get_subagent_result output is changed.

Verification

  • npm run lint
  • npm run typecheck
  • npm run test — 40 passed, 1 skipped; 754 tests passed, 5 skipped
  • npm run build
  • git diff --check upstream/master...HEAD

xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 18, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 21, 2026
@xz-dev
xz-dev force-pushed the fix/conversation-viewer-safe-display branch from cd7eb58 to 5ce5141 Compare July 23, 2026 04:49
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 23, 2026
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 23, 2026
# Conflicts:
#	test/agent-widget.test.ts
#	test/conversation-viewer.test.ts
xz-dev added a commit to xz-dev/pi-subagents-tintinweb that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant