fix(ui): safely render conversation display text#154
Open
xz-dev wants to merge 1 commit into
Open
Conversation
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Jul 18, 2026
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Jul 21, 2026
xz-dev
force-pushed
the
fix/conversation-viewer-safe-display
branch
from
July 23, 2026 04:49
cd7eb58 to
5ce5141
Compare
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Jul 23, 2026
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Jul 23, 2026
# Conflicts: # test/agent-widget.test.ts # test/conversation-viewer.test.ts
xz-dev
added a commit
to xz-dev/pi-subagents-tintinweb
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConversationViewertext[binary content]and visibly escape terminal-unsafe code points without mutating session messagesScope
This is intentionally a separate follow-up to #153 rather than an amendment to that PR. It builds on the exact-width rendering fix already merged there, but the display-safety changes span the viewer, activity and invocation-tag rendering, dependency metadata, and regression coverage.
No agent behavior,
AgentSession.messages, model context, persistence, resume/fork behavior, orget_subagent_resultoutput is changed.Verification
npm run lintnpm run typechecknpm run test— 40 passed, 1 skipped; 754 tests passed, 5 skippednpm run buildgit diff --check upstream/master...HEAD