Fix/sound helper buffer pointer bug - #70
Open
WinTuner wants to merge 6 commits into
Open
Conversation
…Format The code allocated heap memory for WAVEFORMATEXTENSIBLE structs but incorrectly passed pointers to stack variables instead of the allocated heap memory. This caused the property store to read from invalid memory after the function returns.
- Wrap policy creation and property store operations in try/finally to ensure allocated memory is always freed - Fix incorrect Release call on IPolicyConfig interface (use interface pointer instead of original output pointer) - Prevents memory leaks if CoCreateInstance for policy fails or if SetValue/Commit throws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: Stack Pointer vs Heap Pointer (Line 569, 574)
Problem: Code allocated heap memory for WAVEFORMATEXTENSIBLE structs but passed pointers to stack variables instead of the allocated heap memory to the property store.
Fix: Use the allocated heap pointers (pEndpointFormat, pMixFormat) in PROPVARIANT.blob.pBlobData.
Bug 2: AccessViolation / Memory Leaks
Problem: If CoCreateInstance for IPolicyConfig failed, or if SetValue/Commit threw an exception, the allocated memory was never freed. Also, Release was called on the wrong pointer.
Fixes:
Files Changed