Skip to content

refactor: update logger import path and sync dependencies with tinhti… #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ren0503 merged 1 commit into from
Jan 16, 2026
Merged

refactor: update logger import path and sync dependencies with tinhti… #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ go 1.24.0
toolchain go1.24.1

require (
github.com/go-redsync/redsync/v4 v4.14.0
github.com/redis/go-redis/v9 v9.14.1
github.com/go-redsync/redsync/v4 v4.15.0

@coderabbitai coderabbitai Bot Jan 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

go-redsync v4.15.0 release changelog

💡 Result:

I can’t find a go-redsync v4.15.0 release. The official GitHub repository shows releases up to v4.0.4 (latest listed Dec 2, 2020). [1]

Source

  • go-redsync (GitHub releases page). [1]

🌐 Web query:

go-redsync github releases v4.15.0

💡 Result:

I couldn't find a GitHub release or tag named v4.15.0 for go-redsync/redsync. The repository Releases/Tags page has no v4.15.0 (repo root). The most-recent referenced versions in public dependency updates are v4.14.x. [1][2]

Sources:

  • go-redsync/redsync GitHub repository (tags/releases). [1]
  • GitLab dependency update referencing v4.14.0 / v4.14.1. [2]

Would you like me to watch the repo and notify you if v4.15.0 appears?

🏁 Script executed:

#!/bin/bash
# Check if we can find information about go-redsync versions
# Try to fetch from GitHub API or proxy if available
curl -s "https://api.github.com/repos/go-redsync/redsync/releases?per_page=10" 2>/dev/null | head -100 || echo "GitHub API access limited"

Repository: tinh-tinh/queue

Length of output: 4616

Replace v4.15.0 with a valid version—v4.15.0 does not exist.

The version github.com/go-redsync/redsync/v4 v4.15.0 is not found in the official GitHub repository. The latest available releases are v4.0.4 and earlier versions. Update to an existing version or verify the correct version number.

🤖 Prompt for AI Agents 
In `@go.mod` at line 8, The go.mod entry uses a non-existent version for the
Redsync module; replace the invalid version token "v4.15.0" on the line
containing "github.com/go-redsync/redsync/v4" with a real released tag (for
example "v4.0.4") or run a module upgrade to a valid tag and update go.mod
(e.g., change the version literal to an existing release such as v4.0.4 or use
your package manager to resolve the correct tag for
github.com/go-redsync/redsync/v4).

github.com/redis/go-redis/v9 v9.17.2
github.com/robfig/cron/v3 v3.0.1
github.com/stretchr/testify v1.9.0
github.com/tinh-tinh/tinhtinh/v2 v2.3.4
github.com/tinh-tinh/tinhtinh/v2 v2.5.0

@coderabbitai coderabbitai Bot Jan 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

tinhtinh v2.5.0 release notes github

💡 Result:

I couldn't find a GitHub release titled "tinhtinh v2.5.0." I did find the tinhtinh v2 repository listing (shows up via package registries), but no v2.5.0 release notes accessible from search results. (libraries.io)

Would you like me to:

  • keep searching Github (I can try more targeted queries), or
  • search other sources (changelog files, tags, or PyPI/GH Packages) — if you have the exact repo URL, please share it.

Citations:

🌐 Web query:

tinhtinh go package logger middleware common reorganization

💡 Result:

Here’s a concise, practical plan to reorganize the tinhtinh repo around logger / middleware / common while keeping compatibility and clarity.

References: tinhtinh logger docs, examples from other Go middleware projects. [1][2][3]

  1. Goal (one line)
  • Separate concerns: put reusable HTTP middleware in middleware/, core logger implementation in logger/ (or pkg/logger), and shared helpers/types in common/ (or internal/common). Keep clear public API surface.
  1. Suggested tree
  • cmd/...
  • internal/ (non-public helpers)
  • pkg/
    • logger/ (core Logger, Create, Module, Level types) ← public
    • middleware/
      • logger/ (Handler(opt) middleware that uses pkg/logger)
      • recovery/
      • ...
    • common/ (shared format strings, templates, constants) ← public-only if needed
  • go.mod
    (Or if you prefer one public module, use top-level middleware/logger and middleware packages and move truly internal helpers to internal/.)
  1. API & compatibility strategy
  • Keep pkg/logger exports (Logger, Options, Level, Module, Create) — move code but preserve package path if you want zero-break changes. If path must change:
    • Provide thin adapter packages at the old import path that re-export types/funcs with type aliases and wrapper constructors, e.g.:
      package logger // old path
      import newlogger "github.com/tinh-tinh/tinhtinh/pkg/logger"
      type Logger = newlogger.Logger
      func Create(opt newlogger.Options) *Logger { return newlogger.Create(opt) }
    • Mark adapters deprecated and remove in a major version bump.
  • Keep middleware.Handler signature identical (func(http.Handler) http.Handler) so router usage is unchanged. [2][3]
  1. Implementation steps (minimal)
  • Create new directories and move files.
  • Update package names and imports inside repo.
  • Add adapter packages at old paths if changing import path.
  • Run go mod tidy and go test ./...
  • Add CI check for go vet/gofmt/golangci-lint.
  1. Design notes / best practices
  • Put request-specific, framework-agnostic code in pkg/logger; HTTP-specific middleware in middleware/logger. [1][2]
  • Put non-API helpers in internal/ so they’re not imported externally.
  • Use structured logging compatibility (slog or allow pluggable logger interface) to let users swap sinks. [2]
  • For formatting strings/constants (Dev/Common/Combined), put them in common/constants.go and reference from middleware. [1]
  1. Migration checklist for consumers
  • If adapters provided: consumers update at their pace; add deprecation note in README.
  • If no adapters: provide a migration doc with exact old→new import replacements and example git patch.
  1. Quick example adapter (concept)
  • old import: github.com/tinh-tinh/tinhtinh/middleware/logger
  • new implementation moved to: github.com/tinh-tinh/tinhtinh/pkg/middleware/logger
  • adapter (old path) files:
    package logger
    import newlog "github.com/tinh-tinh/tinhtinh/pkg/middleware/logger"
    type MiddlewareOptions = newlog.MiddlewareOptions
    func Handler(opt MiddlewareOptions) func(http.Handler) http.Handler { return newlog.Handler(opt) }
  1. Testing & release
  • Add integration test using a small HTTP router exercising logger middleware.
  • Release as vX.Y.0 and document breaking changes (if any).

If you want, I can:

  • produce the exact file moves and adapter code for your repo (give me current repo layout or link), or
  • draft a migration README and example go.mod changes.

Sources: tinhtinh pkg docs (logger middleware); go-chi httplog (structured middleware example); gorilla handlers (logging middleware pattern). [1][2][3]

🌐 Web query:

site:github.com tinh-tinh/tinhtinh v2.5.0 releases

💡 Result:

I couldn't find a GitHub release or tag named "v2.5.0" for the repository tinh-tinh/tinhtinh. The repository metadata shows v2.1.4 (and related v2 modules) but no v2.5.0 release/tag. [1][2]

Sources:

  • Repository package metadata (shows tinhtinh/v2 at v2.1.4). [1]
  • Project docs/site (Tinh Tinh v2 modules and docs). [2]

🏁 Script executed:

#!/bin/bash
# Read the go.mod file to see current state
cat go.mod

# Search for information about available tinhtinh versions
# Using curl to check the Go module proxy
echo "=== Checking available versions of tinhtinh/v2 ==="
curl -s https://proxy.golang.org/github.com/tinh-tinh/tinhtinh/v2/@v/list 2>/dev/null | head -20

Repository: tinh-tinh/queue

Length of output: 996

Update to v2.4.1: v2.5.0 does not exist.

The specified version v2.5.0 is not available in the Go module registry. The highest released version is v2.4.1. Update the dependency to an actual existing version.

🤖 Prompt for AI Agents 
In `@go.mod` at line 12, The go.mod currently references a non-existent version
"github.com/tinh-tinh/tinhtinh/v2 v2.5.0"; update that module line to a
published version (replace v2.5.0 with v2.4.1) so the dependency resolves
correctly, then run go mod tidy to ensure the module graph and go.sum are
updated; look for the exact module string "github.com/tinh-tinh/tinhtinh/v2" in
go.mod to make the change.

golang.org/x/crypto v0.45.0
)

Expand Down
6 changes: 6 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ github.com/go-redis/redis/v8 v8.11.5 h1:AcZZR7igkdvfVmQTPnu9WE37LRrO/YrBH5zWyjDC
github.com/go-redis/redis/v8 v8.11.5/go.mod h1:gREzHqY1hg6oD9ngVRbLStwAWKhA0FEgq8Jd4h5lpwo=
github.com/go-redsync/redsync/v4 v4.14.0 h1:zyxzFJsmQHIPBl8iBT7KFKohWsjsghgGLiP8TnFMLNc=
github.com/go-redsync/redsync/v4 v4.14.0/go.mod h1:twMlVd19upZ/juvJyJGlQOSQxor1oeHtjs62l4pRFzo=
github.com/go-redsync/redsync/v4 v4.15.0 h1:KH/XymuxSV7vyKs6z1Cxxj+N+N18JlPxgXeP6x4JY54=
github.com/go-redsync/redsync/v4 v4.15.0/go.mod h1:qNp+lLs3vkfZbtA/aM/OjlZHfEr5YTAYhRktFPKHC7s=
github.com/gomodule/redigo v1.9.2 h1:HrutZBLhSIU8abiSfW8pj8mPhOyMYjZT/wcA4/L9L9s=
github.com/gomodule/redigo v1.9.2/go.mod h1:KsU3hiK/Ay8U42qpaJk+kuNa3C+spxapWpM+ywhcgtw=
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
Expand All @@ -27,6 +29,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/redis/go-redis/v9 v9.14.1 h1:nDCrEiJmfOWhD76xlaw+HXT0c9hfNWeXgl0vIRYSDvQ=
github.com/redis/go-redis/v9 v9.14.1/go.mod h1:huWgSWd8mW6+m0VPhJjSSQ+d6Nh1VICQ6Q5lHuCH/Iw=
github.com/redis/go-redis/v9 v9.17.2 h1:P2EGsA4qVIM3Pp+aPocCJ7DguDHhqrXNhVcEp4ViluI=
github.com/redis/go-redis/v9 v9.17.2/go.mod h1:u410H11HMLoB+TP67dz8rL9s6QW2j76l0//kSOd3370=
github.com/redis/rueidis v1.0.64 h1:XqgbueDuNV3qFdVdQwAHJl1uNt90zUuAJuzqjH4cw6Y=
github.com/redis/rueidis v1.0.64/go.mod h1:Lkhr2QTgcoYBhxARU7kJRO8SyVlgUuEkcJO1Y8MCluA=
github.com/redis/rueidis/rueidiscompat v1.0.64 h1:M8JbLP4LyHQhBLBRsUQIzui8/LyTtdESNIMVveqm4RY=
Expand All @@ -39,6 +43,8 @@ github.com/stvp/tempredis v0.0.0-20181119212430-b82af8480203 h1:QVqDTf3h2WHt08Yu
github.com/stvp/tempredis v0.0.0-20181119212430-b82af8480203/go.mod h1:oqN97ltKNihBbwlX8dLpwxCl3+HnXKV/R0e+sRLd9C8=
github.com/tinh-tinh/tinhtinh/v2 v2.3.4 h1:vxhaoPnp3pGNcdXKDG7nVai+V+lYoJHWtm7pzTNapJY=
github.com/tinh-tinh/tinhtinh/v2 v2.3.4/go.mod h1:4nppE7KAIswZKutI9ElMqAD9kyash7aea0Ewowsqj5g=
github.com/tinh-tinh/tinhtinh/v2 v2.5.0 h1:SqCanZJKKgbVsDwoaPe136fZGYoXSKZ6fLciGO0KsoY=
github.com/tinh-tinh/tinhtinh/v2 v2.5.0/go.mod h1:4nppE7KAIswZKutI9ElMqAD9kyash7aea0Ewowsqj5g=
golang.org/x/crypto v0.45.0 h1:jMBrvKuj23MTlT0bQEOBcAE0mjg8mK9RXFhRH6nyF3Q=
golang.org/x/crypto v0.45.0/go.mod h1:XTGrrkGJve7CYK7J8PEww4aY7gM3qMCElcJQ8n8JdX4=
golang.org/x/sync v0.17.0 h1:l60nONMj9l5drqw6jlhIELNv9I0A4OFgRsG9k2oT9Ug=
Expand Down
12 changes: 6 additions & 6 deletions queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/redis/go-redis/v9"
"github.com/robfig/cron/v3"
"github.com/tinh-tinh/tinhtinh/v2/common"
"github.com/tinh-tinh/tinhtinh/v2/middleware/logger"
"github.com/tinh-tinh/tinhtinh/v2/common/logger"
)

type JobFnc func(job *Job)
Expand Down Expand Up @@ -141,10 +141,10 @@ func (q *Queue) BulkAddJob(options []AddJobOptions) {
q.Run()
return
}

// Sort input options by priority once
sort.SliceStable(options, func(i, j int) bool { return options[i].Priority > options[j].Priority })

// Pre-allocate space for new jobs
newJobs := make([]Job, 0, len(options))
for _, option := range options {
Expand All @@ -158,7 +158,7 @@ func (q *Queue) BulkAddJob(options []AddJobOptions) {
}
newJobs = append(newJobs, *job)
}

// Merge sorted slices efficiently
q.jobs = mergeSortedJobs(q.jobs, newJobs)
q.Run()
Expand All @@ -168,7 +168,7 @@ func (q *Queue) BulkAddJob(options []AddJobOptions) {
func mergeSortedJobs(jobs1, jobs2 []Job) []Job {
result := make([]Job, 0, len(jobs1)+len(jobs2))
i, j := 0, 0

for i < len(jobs1) && j < len(jobs2) {
if jobs1[i].Priority >= jobs2[j].Priority {
result = append(result, jobs1[i])
Expand All @@ -178,7 +178,7 @@ func mergeSortedJobs(jobs1, jobs2 []Job) []Job {
j++
}
}

result = append(result, jobs1[i:]...)
result = append(result, jobs2[j:]...)
return result
Expand Down