fix: namespace repeated tool call IDs - #1
Draft
ting-hong-shieh wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Ting-Hong Shieh <32212900+ting-hong-shieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tool_useIDs from the source response ID and tool index.Why
OpenAI-compatible providers may reuse IDs such as
call_0in consecutive responses. Passing those IDs through unchanged creates duplicate Anthropictool_useIDs, which can mispair tool results and leave agent workflows looping.Addresses NVIDIA-NeMo#502.
Depends on NVIDIA-NeMo#397 and is intentionally stacked on
fix/reversible-tool-use-ids.Before / after
Before:
The repeated Anthropic ID made replay ambiguous.
After:
The Anthropic-facing IDs are distinct, while both replay to the provider's original
call_0.How tested
uv run ruff check .uv run mypy switchyarduv run pytest tests/ -v— 147 passed, 2 skippedcargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacecall_0IDs correctlyChecklist
Notes for reviewers