fix: robust handling of undefined sentences in question generation from OCR/PDF - #15
Open
cto-new[bot] wants to merge 1 commit into
Open
Conversation
Fixes a bug where undefined sentences could cause runtime errors during
question generation from extracted PDF or OCR text ("undefined is not an
object (evaluating 'sentence.slice')").
- Adds null/empty checks to sentence.slice() in multiple-choice and
additional question generation flows
- Improves robustness of extractSentences, selectRandomUnused, and
generateQuestions with validation and safer fallbacks
- Provides descriptive error messages for extraction failures
This prevents application crashes from poorly-formed or sparse input,
improves error transparency, and ensures a more resilient one-click
question generation experience for the user.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Free review on us!CodeRabbit is offering free reviews until Fri Nov 07 2025 to showcase some of the refinements we've made. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a runtime bug caused by undefined sentences during question generation from OCR- or PDF-extracted text, ensuring the platform never crashes and provides better error handling for edge cases.
Details
sentence.slice()extractSentences,selectRandomUnused, and related helpers for robust array handlingWarning: Task VM test is not passing, cto.new will perform much better if you fix the setup