feat: Add LFW and Four-corner input methods with UI fixes and layout adjustments - #9
Open
hubpixie wants to merge 4 commits into
Open
feat: Add LFW and Four-corner input methods with UI fixes and layout adjustments#9hubpixie wants to merge 4 commits into
hubpixie wants to merge 4 commits into
Conversation
added 2 commits
August 15, 2026 12:36
…dition to Unicode radicals - Add LFW number and Four-Corner code input methods to achieve practical input speeds, as the current Unicode radical input is inefficient (character by character) - Clean up and update input placeholders - fix(ui): unify clear button colors, fix stroke button hover color for images, and adjust PC layout to prevent overflow matching mobile styling
Owner
|
I've tested your PR, but the four-corner code method requires the L0000 format to be effective. I also found that the LFW output contains a superscript “L,” which is neither in my database nor compliant with scholarly standards. Would you please fix this? Thanks! |
added 2 commits
August 29, 2026 15:55
…t output - Refine input validation logic for "L" prefix (max 4 digits, L0000 format), numeric input (max 6 digits), and restrict numbers when starting with non-L characters - Remove extraneous superscript "L" from LFW output strings to comply with scholarly standards - Align the order of Four-Corner codes in the output
Author
|
Hi, Thank you for the review and for pointing out the issues with the L0000 format and the superscript "L" in the LFW output. I have pushed a new commit addressing all of your feedback:
Could you please take another look at the PR when you have a moment? Thanks again for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant improvements to the input methods and user interface of the Tangut Script Annotation Tool.
Key Changes
New Input Methods:
UI & Layout Fixes:
brightness(0) invert(1)).Testing