config: drop editorial_summary and photos from the Details field mask - #454
Closed
timwangmusic wants to merge 1 commit into
Closed
config: drop editorial_summary and photos from the Details field mask#454timwangmusic wants to merge 1 commit into
timwangmusic wants to merge 1 commit into
Conversation
Commits what the production GCP instance already runs as a local override, so a redeploy from a fresh checkout can't silently resurrect the spend. editorial_summary alone pulls every Place Details call into the Atmosphere billing tier, and photos feeds the photo client's separately-billed image fetches; every reader of both is nil-guarded (nearby_search.go, text_search.go, photos_client.go), so places simply carry no summary/photo. TestDetailedSearchFieldsMask now bans both fields alongside name and user_ratings_total — re-adding either is a deliberate spend decision, not a bug fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YF2pmkEjcz5Uqh2sRgzypQ
Owner
Author
|
Wrong repo — OfferBee's geo work lives on offerbee-ai/Vacation-Planner, where this exact trim already shipped 2026-08-13 (PR #10). Closing as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The production GCP instance already runs with these two fields disabled as a local config override — but master's committed config still requests them, and
TestDetailedSearchFieldsMaskpinned them as required. Any redeploy from a fresh checkout would silently resurrect the spend, and nothing but the Google invoice would say so.editorial_summaryalone pulls every Place Details call into the Atmosphere billing tier;photosfeeds the photo client's separately-billed image fetches. The main consumer driving Details volume (OfferBee's nearby/category/search paths) reads neither.What
config/config.yml:detailed_search_fieldstrimmed to the load-bearing four —opening_hours,formatted_address,adr_address,url.config_yaml_test.go:editorial_summaryandphotosmove from the required list to the banned list, with the rationale in the pin's doc comment — re-adding either is a deliberate spend decision, not a bug fix.Safety
Every reader of both fields is nil-guarded (
nearby_search.go:410/490,text_search.go:347/354,photos_client.go:151), so places simply carry no summary/photo — the behavior production has already had since the instance-side disable, now made durable.Testing
Test-first: the updated pin failed against the old config (both fields flagged), passed after the trim. Full suite green: root,
iowrappers,planner,test/....🤖 Generated with Claude Code
https://claude.ai/code/session_01YF2pmkEjcz5Uqh2sRgzypQ