Expand Visit category search to entertainment venue types - #451
Merged
Conversation
timwangmusic
force-pushed
the
feat/visit-entertainment-types
branch
from
August 2, 2026 16:33
7611be0 to
041b1b8
Compare
GetPlaceTypes(Visit) grows from 4 to 10 Google place types, adding movie_theater, bowling_alley, zoo, aquarium, stadium and tourist_attraction. These were already in placeTypeToCategory (they classify and round-trip to Visit, and could enter the cache via text-search confirms) but were never fetched by a category scan, so nearby-by-category results contained none of these venue types. Cost note: a cold Visit search's per-round fan-out rises from 4 to 10 concurrent Nearby calls. Warm cells are unaffected; cells with a fresh Visit marker pick up the new types when their marker ages out (14 days). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DjdGnZM6cUBeg6jWwoQfU3
timwangmusic
force-pushed
the
feat/visit-entertainment-types
branch
from
August 2, 2026 16:34
041b1b8 to
f9fb253
Compare
tim-eternos
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetPlaceTypes(Visit)grows 4 → 10 types: + movie_theater, bowling_alley, zoo, aquarium, stadium, tourist_attraction. All six are valid legacy Nearby Searchtypevalues and were already classified to Visit inplaceTypeToCategory(the cache round-trip invariant holds —TestPlaceCategoryRoundTripcovers them), but they were never searched — so nearby-by-category results never contained these venue types; they could only enter the cache via one-off text-search confirms.HDELthe<cell>:visitfields fromMapsLastSearchTimefor high-traffic cells.Tests:
TestGetPlaceTypesByCategorypin updated; round-trip invariant green;go vet+ full suite green (7 packages).🤖 Generated with Claude Code
https://claude.ai/code/session_01DjdGnZM6cUBeg6jWwoQfU3