Broaden Eatery category: bar, bakery, meal_takeaway - #445
Merged
Conversation
Food & drink searched only cafe + restaurant, so it had no drink venues and missed bakeries and fast-casual/takeout spots. Add bar, bakery, and meal_takeaway to the Eatery place types (skip meal_delivery — ghost kitchens aren't visitable). - categories.go: new LocationType constants; add all three to GetPlaceTypes(Eatery) and, in lockstep, GetPlaceCategory (the type→category round-trip must stay consistent or the nearby-search cache never hits — guarded by TestPlaceCategoryRoundTrip). - No reward change needed: cardRewards.ts already maps bar/bakery/meal_takeaway to Dining. go build + go test (POI/iowrappers/planner/test) pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cv6h62pnPJZykmbsmppuSy
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "Food & drink" (Eatery) category searched only
cafe+restaurant, so it had no drink venues and missed bakeries and fast-casual/takeout spots (burger joints, taquerias, delis). This broadens coverage of the category.Change
POI/categories.go: addbar,bakery,meal_takeawaytoGetPlaceTypes(Eatery)and — in lockstep — toGetPlaceCategory(the type→category round-trip must stay consistent, or the nearby-search cache writes/reads under mismatched keys and never hits; guarded byTestPlaceCategoryRoundTrip).Skipped
meal_delivery— ghost/delivery-only kitchens aren't places you can visit, so they'd be noise in a "near me" list.No reward-mapping change: OfferBee's
cardRewards.tsalready mapsbar/bakery/meal_takeaway→ Dining.Testing
go build ./...,go test ./POI/... ./iowrappers/... ./planner/... ./test/...pass (incl. the round-trip and place-type-expansion tests, updated for the new Eatery set).Note: legacy Google Nearby Search
typesupports these; richer cuisine types (pizza_restaurant, sushi_restaurant, …) would need a Places API (New) migration — separate effort.