fix(mailer): use DOMAIN env var for email links - #422
Open
Ronnie434 wants to merge 2 commits into
Open
Conversation
Replace hardcoded URLs with the DOMAIN environment variable so email verification and password reset links work across all environments.
Jest exits with code 1 when no test files are found. Adding --passWithNoTests allows CI to pass until tests are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iowrappers/mailer.gowith theDOMAINenvironment variabletestingvs production) in favor of a single config-driven approachhttp://localhost:10000for local development--passWithNoTestsMotivation
The previous implementation had hardcoded URLs (
www.unwind.devfor production,testing-vp.herokuapp.comfor testing). This made it fragile when deploying to different environments. Using theDOMAINenv var (already used elsewhere for OAuth config) makes it consistent and portable.Test plan