Various setup.sh fixes#74
Conversation
* Was failing in a new environment * Added in lines to copy over 'test' config files into production * Added in lines to copy existing production config files when redeploying
There was a problem hiding this comment.
This is needed for deployment. You put your postgressql requirements, etc in the private/requirements file.
Why did you remove it?
There was a problem hiding this comment.
Ah, let me fix that; it was barfing entirely on my machine, causing the whole thing to fall over. Forgot to go back and debug that beyond commenting it out.
There was a problem hiding this comment.
@mithro This is now fixed. Needed || exit 0 added (if file didn't exist, would throw an error, bash would exit)
* /usr/local/var on some systems is chmod 700
* Required for non-dvswitch ALSA sources
* Documentation re 'make distclean' if install fails * Revert Makefile to include private/requirements.txt as per Tim request
* Missing 'make serve' > 'make testserve'
* Added || exit 0, was causing setup.sh to die if file did not exist
|
This is now ready for review. Apologies for all the commits. |
|
poke @mithro |
|
Unlikely I'll get to reviewing this until the weekend or early next week. On 10 August 2014 20:19, Ryan Verner notifications@github.com wrote:
|
|
@xfxf (hope this works here) I have some pending changes too: Have you touched Vagrant ? once you have vagrant apt-get installed, wget http//github..../vagrantfile; but it does't play well with user interaction, like "enter hostname for On Sun, Aug 10, 2014 at 5:19 AM, Ryan Verner notifications@github.com
Carl K |
|
Hi @ryanverner I can't merge this pull request anymore. Can you rebase and update this pull request? |
There was a problem hiding this comment.
I don't think this is in the correct location.
Maybe move it under the # Parts section and make it a subheading.
|
@xfxf When you get a moment, we should look at this pull request and figure out what we need to merge here. |
|
@xfxf Since you might have time now, can you take another look at this? |
4 participants
This was failing on a brand new installation (worked fine for redeploying where it had already been used). Some fixes. Works here now on a brand new Ubuntu 12.04 install.