Skip to content

vagrant to demonstrate install#57

Open
CarlFK wants to merge 17 commits into
timvideos:masterfrom
CarlFK:master
Open

vagrant to demonstrate install#57
CarlFK wants to merge 17 commits into
timvideos:masterfrom
CarlFK:master

Conversation

@CarlFK

@CarlFK CarlFK commented Mar 5, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@mithro

mithro commented Mar 6, 2014

Copy link
Copy Markdown
Member

Can you fix the spelling / punctuation in the commit messages?

You can use git rebase --interactive and then mark the patch as "edit". You can also use that to squash patches together.

Comment thread README Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this symlink?

@CarlFK

CarlFK commented Mar 8, 2014

Copy link
Copy Markdown
Contributor Author

I think I cleaned up all the things you mentioned.

Comment thread website/Makefile Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runserver line should be under the serve target.

Comment thread website/Makefile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong. The line you are removing is correct.

@mithro

mithro commented Sep 7, 2014

Copy link
Copy Markdown
Member

Hi @CarlFK

This pull request no longer merges. Can you please rebase onto the latest and then I'll try merging it.

Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants