Skip to content

chore: refactor mise tasks#137

Merged
timonrieger merged 1 commit into
mainfrom
chore/mise-tasks
Jul 5, 2026
Merged

chore: refactor mise tasks#137
timonrieger merged 1 commit into
mainfrom
chore/mise-tasks

Conversation

@timonrieger

@timonrieger timonrieger commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Updated contributor guidance to reflect the current recommended verification command.
  • Chores

    • Streamlined project task commands for linting, testing, setup, and code generation, with updated CI checks to use the latest workflow commands.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
immichpy Ready Ready Preview Jul 5, 2026 4:07pm

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR renames and reorganizes mise.toml task definitions, replacing the ci:* task prefix scheme with plain task names (install, lint, test:unit, test:e2e). The CI workflow and contributing documentation are updated to reference the renamed tasks accordingly.

Changes

Mise task consolidation

Layer / File(s) Summary
Install and lint task rewiring
mise.toml
install, install:upgrade, install:check now use uv sync with CI-aware --locked behavior; setup, lint, and lint:fix depend on install and use uvx prek.
Unit and e2e test task aggregation
mise.toml
test:unit/test:e2e aggregate test:unit:cli, test:unit:client, test:e2e:cli, test:e2e:client via depends; prior CI-specific test tasks removed.
Generation and docs generation task simplification
mise.toml
generate:client/generate:cli simplified to direct uv run commands; docs:generate:cli/docs:generate:client depend on install; ci:gen rewritten to chain generation, stage files, and run lint:fix.
CI workflow and contributing docs updates
.github/workflows/cd.yml, docs/info/contributing.md
Lint, unit test, and e2e test steps in CI call mise run lint, test:unit, test:e2e; PR checklist command updated to mise run lint.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: a refactor of mise task definitions and related workflow updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/mise-tasks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@mise.toml`:
- Line 14: The mise tasks are using the wrong Prek subcommand, so update the
relevant entries in mise.toml from the current prek update usage to prek
auto-update with the non-mutating check flag. Make this change in both places
that define the Prek update behavior so the run tasks match the supported
command and preserve the existing dry-run/check semantics.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0dafbaab-2869-4b1b-8838-daa628f3fa98

📥 Commits

Reviewing files that changed from the base of the PR and between 1b8302f and 4926b4b.

📒 Files selected for processing (3)
  • .github/workflows/cd.yml
  • docs/info/contributing.md
  • mise.toml

Comment thread mise.toml
@timonrieger timonrieger merged commit 3694345 into main Jul 5, 2026
11 checks passed
@timonrieger timonrieger deleted the chore/mise-tasks branch July 5, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant