Feat: Deploy PowerProxy via Terraform - #2
Open
clemlesne wants to merge 9 commits into
Open
Conversation
clemlesne
force-pushed
the
feat/terraform-deploy
branch
from
September 25, 2023 17:13
f634a62 to
bb3c6a1
Compare
timoklimmer
requested changes
Sep 26, 2023
timoklimmer
left a comment
timoklimmer
left a comment
Owner
There was a problem hiding this comment.
- Please remove all the changes not related to the Terraform deployment, like changes in launch.json, settings.json, config.py, dicts.py, LogUsageToLogAnalytics.py, base.py, powerproxy.py, config.example.yaml.
- Besides, .gitignore should exclude only relevant files, not files with "arbitrary" extensions.
- Also please improve the documentation.
- PowerProxy will automatically take a config string from env var POWERPROXY_CONFIG_STRING if available.
- I think it would be good if we include code to deploy a Log Analytics etc. but no Azure OpenAI resource.
clemlesne
force-pushed
the
feat/terraform-deploy
branch
from
September 29, 2023 15:46
bb3c6a1 to
55ad85c
Compare
Contributor
Author
|
Commit 55ad85c:
|
clemlesne
force-pushed
the
feat/terraform-deploy
branch
2 times, most recently
from
October 9, 2023 08:10
55a8b36 to
81f1547
Compare
- Configuration file is took from "[workspace]/config" folder - OpenAI deployments are not touched - Container App resource links with a the created App Insight, for Azure native metrics - Log Analytics Table is created automatically, even if neither ARM or Terraform resource is available, this should be fixed when resource will be available from the AzureRM provider
clemlesne
force-pushed
the
feat/terraform-deploy
branch
from
October 9, 2023 08:12
81f1547 to
afae83a
Compare
timoklimmer
changed the title
Owner
|
Azure Redis Cache has been added meanwhile. Therefore, would need to be considered in the TerraForm templates as well. |
|
Looking forward, for a terraform implementation. This would really help our project! |
krohm
reviewed
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Requires to be merged after #1.