Skip to content

make it compatible for pytorch latest version - #13

Open
jizongFox wants to merge 1 commit into
timgaripov:masterfrom
jizongFox:master
Open

make it compatible for pytorch latest version#13
jizongFox wants to merge 1 commit into
timgaripov:masterfrom
jizongFox:master

Conversation

@jizongFox

Copy link
Copy Markdown

Hi, just noticed this wonderful work. I have made this code available for latest PyTorch version by providing minor revisions. Please consider merging.

@izmailovpavel

izmailovpavel commented Sep 29, 2019

Copy link
Copy Markdown
Collaborator

Hi @jizongFox thanks for the PR. I will be able to take a close look in a week or so. I don't know if we want to add tqdm in adjust_learning_rate. If we do, why not in the train epoch as well?
Also, I guess we would want to somehow preserve compatibility with older PyTorch versions?
@timgaripov what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants