fix(core): promote to BigInt instead of panicking on neg/abs of i64::MIN 💥#172
Merged
Conversation
…MIN 💥 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6594f37 to
0ff827e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Continuing the recent sweep of panic-on-edge-case fixes (negative power,
windowssize 0, integer division by zero), I went looking for another arithmetic input that crashes the interpreter. Negating or taking the absolute value ofi64::MINdoes it: the positive magnitude2^63does not fit in ani64.Int::absandInt::negcalledi.abs()/i.neg()directly on theInt64variant. Both overflow ati64::MIN, panicking with "attempt to negate with overflow" in debug builds and silently wrapping to a negative result in release.Changes
ndc_core/src/int.rs:Int::absandInt::negnow usechecked_abs/checked_negand promote toBigInton overflow, matching the checked-then-promote pattern already used by the binary operators.001_math/032_neg_abs_i64_min.ndcand900_bugs/bug0026_neg_abs_i64_min_overflow.ndc.Every other path produces the same results as before; only the
i64::MINboundary changes from a panic to the correct9223372036854775808.🤖