Skip to content

fix(windows): use glow renderer for Windows builds - #102

Merged
timcogan merged 2 commits into
masterfrom
fix/windows-glow-renderer
Jul 10, 2026
Merged

fix(windows): use glow renderer for Windows builds#102
timcogan merged 2 commits into
masterfrom
fix/windows-glow-renderer

Conversation

@timcogan

@timcogan timcogan commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved release version validation across environments by using more portable pattern matching.
    • Updated platform-specific application configuration to improve compatibility and support Windows accessibility features, fonts, and graphics rendering.
  • Chores
    • Refined dependency configuration to provide a more consistent experience across supported operating systems.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@timcogan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13672578-4ce2-440d-a6ce-70f33e044e4d

📥 Commits

Reviewing files that changed from the base of the PR and between 379f5b1 and 7777632.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

The changes configure eframe dependencies by target platform and update CI’s awk release-version parsing to use POSIX whitespace classes.

Changes

Platform dependency configuration

Layer / File(s) Summary
Target-specific eframe configuration
Cargo.toml
The general dependency list no longer includes eframe; Windows enables additional features, while non-Windows uses the default configuration.

Release version validation

Layer / File(s) Summary
POSIX-compatible version parsing
.github/workflows/ci.yml
Release version extraction now uses [[:space:]] patterns while preserving the existing validation flow.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required template sections are entirely missing. Add the required Summary, Testing, Screenshots if applicable, and Checklist sections, and briefly note what changed and how it was tested.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly matches the main change: enabling the glow renderer for Windows builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-glow-renderer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timcogan

Copy link
Copy Markdown
Owner Author

@coderabbitai

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

@timcogan Hi! I see you've tagged me, but I don't see a specific question or request in your message. Could you let me know what you'd like help with regarding this PR? For example, I can:

  • Review the changes
  • Answer questions about the glow renderer / Windows build fix
  • Help investigate specific code or issues
  • Make configuration changes

Just let me know what you need!

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 34-36: Update both release manifest-version parsers in the release
workflow to use the same POSIX-whitespace-tolerant patterns as the CI parser:
allow surrounding whitespace for the [package] header and whitespace around the
version assignment. Keep both release extraction paths consistent, or centralize
the shared parsing logic to prevent future divergence.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 494cf479-97d2-4a62-9d54-96ac72fac1f4

📥 Commits

Reviewing files that changed from the base of the PR and between f9215a0 and 379f5b1.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • Cargo.toml

Comment thread .github/workflows/ci.yml
@timcogan
timcogan merged commit 4ab0f05 into master Jul 10, 2026
10 checks passed
@timcogan
timcogan deleted the fix/windows-glow-renderer branch July 10, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant