ci: add SonarQube coverage pipeline (blueprint) - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a SonarQube coverage pipeline for Telegraph. Draft — the build approach needs to change (see below).
Corrected diagnosis (why the xcworkspace approach fails)
tillhub/Telegraphis a fork ofBuilding42/Telegraphwhose purpose is to depend on the patchedtillhub/CocoaAsyncSocket7.6.7 (a tag that doesn't exist upstream) — wired throughPackage.swift(SPM):The legacy
Telegraph.xcworkspace/Telegraph iOSscheme was inherited from upstream and never updated for the fork:XCRemoteSwiftPackageReferencestill points atrobbiehanson/CocoaAsyncSocket(7.6.4) — so building via the scheme ignores the fork's whole point;Telegraph Teststarget links neitherTelegraph.frameworknor setsBUNDLE_LOADER(host app links nothing) →ld: framework 'Telegraph' not found.Upstream Building42 CI uses that same legacy scheme (and a stale
iPhone 14 Prosim), so it isn't a reliable blueprint either.Recommended fix (low-risk, no .pbxproj surgery)
Test via SPM instead of the xcworkspace:
swift build/swift test --enable-code-coverageagainstPackage.swift(resolves the tillhub CocoaAsyncSocket 7.6.7 fork;TelegraphTestscorrectly depends onTelegraph).xcrun llvm-cov export -format=lcov …→ convert lcov to Sonar generic format forsonar.coverageReportPaths(the xccov script in this PR does not apply to SPM).Telegraph.xcworkspace.The
sonarqube.yamlscan config here (sourcesSources, testsTests) is still valid; only the Unit Tests build step needs to move to SPM.🤖 Generated with Claude Code