Repository navigation
fix: update integration tests for paginated JSON schema - #78
Merged
Merged
Conversation
JSON output from list commands now returns { items: [...] } instead of
a flat array. Update the two integration tests that parsed JSON output
as flat arrays to use parsed.items instead.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ovaistariq
approved these changes
Apr 8, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e6551c. Configure here.
The beforeAll cleanup also parsed buckets list JSON as a flat array. Silently failed in the catch block, leaving stale test buckets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[...]) to use the new paginated schema ({ items: [...] })should list buckets with --format jsonandshould list snapshots with --format jsonsnapshotVersioncorrectlyTest plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk because changes are limited to test assertions and JSON parsing logic to match a new
{ items: [...] }response shape; no production code paths are modified.Overview
Updates
test/cli.test.tsto expect paginated JSON output ({ items: [...] }) instead of a top-level array forbuckets list --format jsonandsnapshots list --format json.Adjusts the stale test-bucket sweeper and snapshot version extraction to read from
parsed.items, preventing cascading failures in snapshot-version-dependent tests.Reviewed by Cursor Bugbot for commit 0e075ee. Bugbot is set up for automated code reviews on this repo. Configure here.