Repository navigation
fix: use resolveAuthMethod() in IAM config helpers - #63
Merged
Merged
Conversation
designcode
force-pushed
the
fix/iam-auth-resolution
branch
from
April 2, 2026 17:20
fc62eb1 to
cb589a5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ovaistariq
approved these changes
Apr 2, 2026
getIAMConfig() had its own auth resolution logic that diverged from resolveAuthMethod(), missing AWS profiles and env var credentials. Now delegates to resolveAuthMethod() as the single source of truth. getOAuthIAMConfig() keeps using the stored login method since IAM user/policy operations always require OAuth, even when env vars or AWS profile override S3 auth. Also moves isFlyOrganization() into auth/fly.ts where isFlyUser() lives, and deduplicates the inline check in organizations/create.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
designcode
force-pushed
the
fix/iam-auth-resolution
branch
from
April 2, 2026 17:56
6d9b28f to
bf112a3
Compare
Contributor
|
🎉 This PR is included in version 2.14.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getIAMConfig()andgetOAuthIAMConfig()had their own auth resolution logic that diverged fromresolveAuthMethod(), missing AWS profiles and env var credentials. Now both delegate toresolveAuthMethod()as the single source of truth.isFlyOrganization()intoauth/fly.tswhereisFlyUser()lives, and deduplicates the inline check inorganizations/create.ts.Test plan
npm run buildpassesnpm run formatandnpm run lint:fixclean🤖 Generated with Claude Code
Note
Medium Risk
Changes IAM authentication selection to follow
resolveAuthMethod(), which can alter how credentials are chosen (AWS profile/env vs OAuth) for IAM commands and potentially affect access in edge cases. Also refactors Fly.io organization restrictions into a shared helper, with low functional risk.Overview
Aligns IAM config construction with
resolveAuthMethod()sogetIAMConfig()consistently supports AWS profiles and environment/configured credentials (matchinggetStorageConfig()priority) while keepinggetOAuthIAMConfig()strictly OAuth-only.Moves Fly.io organization gating into
auth/fly.tsasisFlyOrganization(feature)and updates IAM user-management commands andorganizations createto use the shared, feature-specific message instead of duplicated checks.Written by Cursor Bugbot for commit bf112a3. This will update automatically on new commits. Configure here.