Repository navigation
fix: clear stale auth state on re-login - #60
Merged
Merged
Conversation
Extend lint, lint:fix, format, and format:check to cover test/**/*.ts alongside src. Fix import ordering and formatting across all test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Allow OAuth re-login (remove isAuthenticated block) and clear the other method's temporary state when switching login methods to prevent stale sessions from persisting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovaistariq
approved these changes
Mar 31, 2026
Add resolveAuthMethod() as a single source of truth for the auth priority chain (AWS profile → OAuth → credentials login → env vars → configured). Refactor getStorageConfig() to use it, and rewrite whoami to display the active auth method with IAM identity for credential-based methods. Move getEnvCredentials, getEnvCredentialSource, and getCredentials from storage.ts to provider.ts where they belong as auth resolution logic. Add comprehensive tests for resolveAuthMethod() covering all 5 auth methods, priority ordering, and edge cases (19 tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Single function now returns credentials with source field, eliminating duplicated env var logic and the inconsistency flagged in PR review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New priority: AWS profile → env vars → oauth → credentials → configured. Env vars are explicit per-session overrides and should win over a previously stored login. Also replace unnecessary dynamic import of getStorageConfig in whoami with the existing static import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AWS_ variables are the standard and should be checked before TIGRIS_ in getTigrisConfig() and getEnvCredentials(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
When clearOAuthData() is called without first updating activeMethod, resolveAuthMethod() would return oauth but no tokens exist, causing getStorageConfig() to crash on authClient.getAccessToken(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.14.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAuthenticated()early-return blockcredentials.temporaryfrom a previous credentials sessioncredentials.saved(fromtigris configure) is always preservedTest plan
npm run build— cleannpm run test— 510 tests passnpm run format && npm run lint:fix— cleantigris login(OAuth), thentigris login --access-key ... --access-secret ...— verify OAuth state is clearedtigris login --access-key ... --access-secret ..., thentigris login(OAuth) — verify temporary credentials are clearedtigris configure, then re-login with either method — verify saved credentials persist🤖 Generated with Claude Code
Note
Medium Risk
Touches core authentication/credential resolution and endpoint/env-var precedence, which can change how existing users are authenticated in different environments; mitigated by new unit tests but still broad behavioral impact.
Overview
Improves auth resolution and re-login behavior by making auth-method precedence explicit (
AWS_PROFILE�� env vars �� stored login �� configured creds) via a newresolveAuthMethod()and updatedgetStorageConfig()/whoamiflows.Fixes stale session cross-contamination by clearing previous state on successful login: OAuth login now clears temporary credential sessions, and credentials login clears all OAuth tokens/org state; adds storage helpers (
clearTemporaryCredentials,clearOAuthData) and tests covering the new priority ordering. Also updates lint/format scripts to includetest/and includes various test-only formatting/import cleanups.Written by Cursor Bugbot for commit 81ee7fe. This will update automatically on new commits. Configure here.