Repository navigation
feat: simplify pre-signing urls - #58
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…th paths - Export keyMatchesOperation and use it in both auto-resolve and interactive prompt paths for consistent role+method filtering - Add unit tests for keyMatchesOperation covering get/put methods, NamespaceAdmin, wildcard buckets, and edge cases - Simplify test script to auto-discover test files via vitest config - Remove -i alias from --select flag Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovaistariq
approved these changes
Mar 30, 2026
MantasMiksys
approved these changes
Mar 30, 2026
Contributor
|
🎉 This PR is included in version 2.14.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how
presignchooses an access key during OAuth login by auto-selecting based on bucket/role/method, which could alter behavior or fail in edge role configurations. Adds new CLI surface area (--select) and updates test execution defaults, but no changes to signing or network APIs beyond key selection.Overview
Simplifies
presignaccess-key resolution for OAuth logins by defaulting to an automatic selection of an active access key that matches the target bucket and requested operation (getvsput), with clearer errors when no suitable key exists.Adds an explicit
--selectflag to opt into interactive key selection (TTY-only), and introduces/exportskeyMatchesOperationwith new unit tests to validate role/bucket matching (includingNamespaceAdmin).Test tooling is adjusted:
npm testnow excludes the integration CLI test file by default, and Vitest output is set toverbose.Written by Cursor Bugbot for commit f6c453f. This will update automatically on new commits. Configure here.