Generate the types file when --types is passed as a boolean - #892
Open
lazerg wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@bakerkretzmar since you already reviewed #891, mind taking a look at this one too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--typesas a boolean (e.g.Artisan::call('ziggy:generate', ['--types' => true]), which is the convention Laravel documents for boolean options) coerces the value to the string"1", which then falls through thematchinCommandRouteGeneratorand gets used as the types file's path, so the declaration file is written to a file named1in the project root instead of at the default location. This adds the coerced boolean value to the arm that already handlesfalse/null, so a boolean--typesgenerates the types file at the default path as expected.Closes #879.