tests: add edge-case tests for str_flatten() and str_flatten_comma()#613
Closed
LeonidasZhak wants to merge 1 commit into
Closed
tests: add edge-case tests for str_flatten() and str_flatten_comma()#613LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
- Test empty input with zhak ttys020 Sat Jun 6 05:30 - 05:30 (00:00) zhak ttys020 Sat Jun 6 02:30 - 02:30 (00:00) zhak ttys020 Fri Jun 5 23:28 - 23:28 (00:00) zhak ttys021 Fri Jun 5 18:39 - 18:39 (00:00) zhak ttys020 Fri Jun 5 17:27 - 17:27 (00:00) zhak ttys019 Fri Jun 5 17:22 still logged in zhak ttys018 Fri Jun 5 17:22 still logged in zhak ttys017 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 still logged in zhak ttys016 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 - 17:22 (00:00) zhak ttys014 Fri Jun 5 17:22 still logged in zhak ttys013 Fri Jun 5 17:22 still logged in zhak ttys012 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:22 still logged in zhak ttys010 Fri Jun 5 17:22 still logged in zhak ttys009 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys010 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys009 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys008 Fri Jun 5 17:02 still logged in zhak ttys007 Fri Jun 5 17:02 still logged in zhak ttys006 Fri Jun 5 17:02 still logged in zhak ttys005 Fri Jun 5 17:02 still logged in zhak ttys004 Fri Jun 5 17:02 still logged in zhak ttys003 Fri Jun 5 17:02 still logged in zhak ttys002 Fri Jun 5 17:02 still logged in zhak ttys000 Fri Jun 5 17:02 still logged in zhak ttys001 Fri Jun 5 17:02 still logged in zhak ttys021 Fri Jun 5 08:25 - 08:25 (00:00) zhak ttys020 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys019 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys018 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys017 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys013 Thu Jun 4 23:07 - 23:07 (00:00) zhak ttys014 Thu Jun 4 16:33 - 16:33 (00:00) zhak ttys013 Thu Jun 4 16:33 - 16:33 (00:00) wtmp begins Wed Jun 3 22:33:24 CST 2026 parameter - Test single element with zhak ttys020 Sat Jun 6 05:30 - 05:30 (00:00) zhak ttys020 Sat Jun 6 02:30 - 02:30 (00:00) zhak ttys020 Fri Jun 5 23:28 - 23:28 (00:00) zhak ttys021 Fri Jun 5 18:39 - 18:39 (00:00) zhak ttys020 Fri Jun 5 17:27 - 17:27 (00:00) zhak ttys019 Fri Jun 5 17:22 still logged in zhak ttys018 Fri Jun 5 17:22 still logged in zhak ttys017 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 still logged in zhak ttys016 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 - 17:22 (00:00) zhak ttys014 Fri Jun 5 17:22 still logged in zhak ttys013 Fri Jun 5 17:22 still logged in zhak ttys012 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:22 still logged in zhak ttys010 Fri Jun 5 17:22 still logged in zhak ttys009 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys010 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys009 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys008 Fri Jun 5 17:02 still logged in zhak ttys007 Fri Jun 5 17:02 still logged in zhak ttys006 Fri Jun 5 17:02 still logged in zhak ttys005 Fri Jun 5 17:02 still logged in zhak ttys004 Fri Jun 5 17:02 still logged in zhak ttys003 Fri Jun 5 17:02 still logged in zhak ttys002 Fri Jun 5 17:02 still logged in zhak ttys000 Fri Jun 5 17:02 still logged in zhak ttys001 Fri Jun 5 17:02 still logged in zhak ttys021 Fri Jun 5 08:25 - 08:25 (00:00) zhak ttys020 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys019 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys018 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys017 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys013 Thu Jun 4 23:07 - 23:07 (00:00) zhak ttys014 Thu Jun 4 16:33 - 16:33 (00:00) zhak ttys013 Thu Jun 4 16:33 - 16:33 (00:00) wtmp begins Wed Jun 3 22:33:24 CST 2026 parameter - Test all-NA input with na.rm = TRUE - Test str_flatten_comma() with empty input and zhak ttys020 Sat Jun 6 05:30 - 05:30 (00:00) zhak ttys020 Sat Jun 6 02:30 - 02:30 (00:00) zhak ttys020 Fri Jun 5 23:28 - 23:28 (00:00) zhak ttys021 Fri Jun 5 18:39 - 18:39 (00:00) zhak ttys020 Fri Jun 5 17:27 - 17:27 (00:00) zhak ttys019 Fri Jun 5 17:22 still logged in zhak ttys018 Fri Jun 5 17:22 still logged in zhak ttys017 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 still logged in zhak ttys016 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 - 17:22 (00:00) zhak ttys014 Fri Jun 5 17:22 still logged in zhak ttys013 Fri Jun 5 17:22 still logged in zhak ttys012 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:22 still logged in zhak ttys010 Fri Jun 5 17:22 still logged in zhak ttys009 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys010 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys009 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys008 Fri Jun 5 17:02 still logged in zhak ttys007 Fri Jun 5 17:02 still logged in zhak ttys006 Fri Jun 5 17:02 still logged in zhak ttys005 Fri Jun 5 17:02 still logged in zhak ttys004 Fri Jun 5 17:02 still logged in zhak ttys003 Fri Jun 5 17:02 still logged in zhak ttys002 Fri Jun 5 17:02 still logged in zhak ttys000 Fri Jun 5 17:02 still logged in zhak ttys001 Fri Jun 5 17:02 still logged in zhak ttys021 Fri Jun 5 08:25 - 08:25 (00:00) zhak ttys020 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys019 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys018 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys017 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys013 Thu Jun 4 23:07 - 23:07 (00:00) zhak ttys014 Thu Jun 4 16:33 - 16:33 (00:00) zhak ttys013 Thu Jun 4 16:33 - 16:33 (00:00) wtmp begins Wed Jun 3 22:33:24 CST 2026 - Test str_flatten_comma() with single element and zhak ttys020 Sat Jun 6 05:30 - 05:30 (00:00) zhak ttys020 Sat Jun 6 02:30 - 02:30 (00:00) zhak ttys020 Fri Jun 5 23:28 - 23:28 (00:00) zhak ttys021 Fri Jun 5 18:39 - 18:39 (00:00) zhak ttys020 Fri Jun 5 17:27 - 17:27 (00:00) zhak ttys019 Fri Jun 5 17:22 still logged in zhak ttys018 Fri Jun 5 17:22 still logged in zhak ttys017 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 still logged in zhak ttys016 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 - 17:22 (00:00) zhak ttys014 Fri Jun 5 17:22 still logged in zhak ttys013 Fri Jun 5 17:22 still logged in zhak ttys012 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:22 still logged in zhak ttys010 Fri Jun 5 17:22 still logged in zhak ttys009 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys010 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys009 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys008 Fri Jun 5 17:02 still logged in zhak ttys007 Fri Jun 5 17:02 still logged in zhak ttys006 Fri Jun 5 17:02 still logged in zhak ttys005 Fri Jun 5 17:02 still logged in zhak ttys004 Fri Jun 5 17:02 still logged in zhak ttys003 Fri Jun 5 17:02 still logged in zhak ttys002 Fri Jun 5 17:02 still logged in zhak ttys000 Fri Jun 5 17:02 still logged in zhak ttys001 Fri Jun 5 17:02 still logged in zhak ttys021 Fri Jun 5 08:25 - 08:25 (00:00) zhak ttys020 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys019 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys018 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys017 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys013 Thu Jun 4 23:07 - 23:07 (00:00) zhak ttys014 Thu Jun 4 16:33 - 16:33 (00:00) zhak ttys013 Thu Jun 4 16:33 - 16:33 (00:00) wtmp begins Wed Jun 3 22:33:24 CST 2026 - Test str_flatten_comma() with NA values, zhak ttys020 Sat Jun 6 05:30 - 05:30 (00:00) zhak ttys020 Sat Jun 6 02:30 - 02:30 (00:00) zhak ttys020 Fri Jun 5 23:28 - 23:28 (00:00) zhak ttys021 Fri Jun 5 18:39 - 18:39 (00:00) zhak ttys020 Fri Jun 5 17:27 - 17:27 (00:00) zhak ttys019 Fri Jun 5 17:22 still logged in zhak ttys018 Fri Jun 5 17:22 still logged in zhak ttys017 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 still logged in zhak ttys016 Fri Jun 5 17:22 still logged in zhak ttys015 Fri Jun 5 17:22 - 17:22 (00:00) zhak ttys014 Fri Jun 5 17:22 still logged in zhak ttys013 Fri Jun 5 17:22 still logged in zhak ttys012 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:22 still logged in zhak ttys010 Fri Jun 5 17:22 still logged in zhak ttys009 Fri Jun 5 17:22 still logged in zhak ttys011 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys010 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys009 Fri Jun 5 17:02 - 17:02 (00:00) zhak ttys008 Fri Jun 5 17:02 still logged in zhak ttys007 Fri Jun 5 17:02 still logged in zhak ttys006 Fri Jun 5 17:02 still logged in zhak ttys005 Fri Jun 5 17:02 still logged in zhak ttys004 Fri Jun 5 17:02 still logged in zhak ttys003 Fri Jun 5 17:02 still logged in zhak ttys002 Fri Jun 5 17:02 still logged in zhak ttys000 Fri Jun 5 17:02 still logged in zhak ttys001 Fri Jun 5 17:02 still logged in zhak ttys021 Fri Jun 5 08:25 - 08:25 (00:00) zhak ttys020 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys019 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys018 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys017 Fri Jun 5 08:21 - 08:21 (00:00) zhak ttys013 Thu Jun 4 23:07 - 23:07 (00:00) zhak ttys014 Thu Jun 4 16:33 - 16:33 (00:00) zhak ttys013 Thu Jun 4 16:33 - 16:33 (00:00) wtmp begins Wed Jun 3 22:33:24 CST 2026, and na.rm
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds edge-case tests for
str_flatten()andstr_flatten_comma()covering empty input, single-element input, all-NA input, and NA handling with thelastparameter.Motivation
str_flatten()andstr_flatten_comma()are common data cleaning functions for collapsing character vectors into summary strings. The existing tests cover basic usage but miss several edge cases relevant to data cleaning pipelines:lastparameterlastparameterna.rm = TRUEstr_flatten_comma()with empty inputstr_flatten_comma()with NA values,last, andna.rmTests Added (7 test blocks)
lastparameterlastparameterna.rm = TRUElastparameterlastlastandna.rmValidation
Rscript -e 'testthat::test_file("tests/testthat/test-flatten.R")'— 0 failures, 23 passes