Skip to content

Fix html_table(fill) deprecation attribution - #489

Open
hadley wants to merge 1 commit into
mainfrom
fix-html-table-fill-env
Open

hadley wants to merge 1 commit into
mainfrom
fix-html-table-fill-env

Conversation

@hadley

@hadley hadley commented Oct 9, 2026

Copy link
Copy Markdown
Member

🤖 Written by AI 🤖

The html_table(fill) deprecation warning blamed rvest ("likely used in the rvest package") when called on an xml_document or xml_nodeset, because those methods re-dispatch to the xml_node method. Spotted in the teal.widgets revdep check.

Check `fill` once in the generic so the warning blames the caller rather than rvest when called on a document or nodeset.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant