MOD-2833 : Add properties, events and method for TagTechnologyNfcV (ISO15693) - #46
Open
anil-shukla-axway wants to merge 4 commits into
Open
MOD-2833 : Add properties, events and method for TagTechnologyNfcV (ISO15693)#46anil-shukla-axway wants to merge 4 commits into
anil-shukla-axway wants to merge 4 commits into
Conversation
Contributor
Author
|
@fasihul-axway Please review this PR. |
|
anil-shukla-axway
force-pushed
the
MOD-2833
branch
from
March 17, 2021 07:35
4dd5487 to
8fdee8b
Compare
fasihul-haque
suggested changes
Mar 17, 2021
fasihul-haque
left a comment
fasihul-haque
left a comment
There was a problem hiding this comment.
@anil-shukla-axway, please add api documentation, i do not see any YML document with this PR.
fasihul-haque
suggested changes
Mar 18, 2021
There was a problem hiding this comment.
@anil-shukla-axway, please see my comment, i think some code refinement required before merging this PR. Once you done with changes, please update YML accordingly.
| uint8_t requestFlags = [requestFlagsValue unsignedCharValue]; | ||
|
|
||
| [[self.tagProxy asNFCISO15693Tag] getMultipleBlockSecurityStatusWithRequestFlag:requestFlags | ||
| blockRange:NSMakeRange(0, 8) |
There was a problem hiding this comment.
Why using hardcoded blockRange? As per apple documentation range should be "The range of blocks. Valid start index range is 0 to 255 inclusively. Valid length is 1 to 256 inclusively."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/MOD-2833