Repository navigation
Wrap unsigned public activities for relay subscribers - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Mastodon interoperability for unsigned public activities received from
publishers such as the WordPress ActivityPub plugin.
Traditional relay subscribers previously received the original source activity
signed with the relay's HTTP key. For unsigned source activities, that produced
a mismatch between:
Mastodon accepted these deliveries with HTTP 202 but silently stopped
processing them before importing the status.
Behavior
relay-authored Announce for traditional subscribers and follower-style
receivers.
RsaSignature2017 shape retain exact-body forwarding to traditional
subscribers.
those LD-signed activities.
forwarded with a signer/actor mismatch.
Activity-Relay only recognizes the expected LD-signature shape. The receiving
server remains responsible for cryptographic proof verification.
Interoperability evidence
An isolated WordPress blog-actor test established:
Mastodon knew the WordPress Group actor, had relay2 enabled, and had neither
suspended nor silenced the actor. Its processing workers completed immediately
without fetching or storing the object. The source activity was unsigned, so
the relay HTTP signer differed from the top-level WordPress actor.
Validation
Prospective validation passed before applying the exact patch:
Validated tree:
Validated patch SHA-256: