Repository navigation
Improve mixed-profile signed fetch interoperability - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes two mixed-profile signed-fetch interoperability gaps found during the Activity-Relay 3.0 interoperability matrix:
400 Bad Requestonce with the legacy HTTP Signature profile for an unknown fetch destination, and cache legacy only after that fallback succeeds.#main-keydo not contaminate@target-uri.Scope and safety
400case.successful_legacy_fallbacksuccessful_rfc9421Validation
go vet400200200401200Known downstream limitation
NodeBB currently performs an unauthenticated or otherwise unusable canonical-object fetch when processing a relayed Mastodon object under authorized-fetch mode. Mastodon returns
401, and NodeBB returns424 Failed Dependencyto the relay. This is downstream of Activity-Relay and will be investigated separately in a NodeBB fork.